Am 20.01.2024 um 18:21 hat Peter Maydell geschrieben: > On Fri, 19 Jan 2024 at 18:15, Kevin Wolf <[email protected]> wrote: > > > > The following changes since commit 3f2a357b95845ea0bf7463eff6661e43b97d1afc: > > > > Merge tag 'hw-cpus-20240119' of https://github.com/philmd/qemu into > > staging (2024-01-19 11:39:38 +0000) > > > > are available in the Git repository at: > > > > https://repo.or.cz/qemu/kevin.git tags/for-upstream > > > > for you to fetch changes up to ced0d71c5270bed828ed2bd4b116ddfb12862bf9: > > > > block/blklogwrites: Protect mutable driver state with a mutex. > > (2024-01-19 18:45:44 +0100) > > > > ---------------------------------------------------------------- > > Block layer patches > > > > - virtio-blk: Multiqueue fixes and cleanups > > - blklogwrites: Fixes for write_zeroes and superblock update races > > - commit/stream: Allow users to request only format driver names in > > backing file format > > - monitor: only run coroutine commands in qemu_aio_context > > > > ---------------------------------------------------------------- > > Got some compile failures on this one; looks like the compiler > on our s390 box didn't like this: > > https://gitlab.com/qemu-project/qemu/-/jobs/5973441293 > https://gitlab.com/qemu-project/qemu/-/jobs/5973441291 > https://gitlab.com/qemu-project/qemu/-/jobs/5973441330 > > In file included from ../include/qemu/host-utils.h:33, > from ../include/qemu/bitops.h:16, > from ../include/qemu/timer.h:4, > from ../include/block/aio.h:24, > from ../include/block/aio-wait.h:28, > from ../include/block/block-io.h:27, > from ../block/blklogwrites.c:15: > ../block/blklogwrites.c: In function ‘blk_log_writes_co_do_log’: > ../include/qemu/bswap.h:148:36: error: left shift count >= width of > type [-Werror=shift-count-overflow] > 148 | ((((_x) & 0x00000000000000ffU) << 56) | \ > | ^~ > ../block/blklogwrites.c:409:27: note: in expansion of macro ‘const_le64’ > 409 | .nr_entries = const_le64(0), > | ^~~~~~~~~~ > ../include/qemu/bswap.h:149:36: error: left shift count >= width of > type [-Werror=shift-count-overflow] > 149 | (((_x) & 0x000000000000ff00U) << 40) | \ > | ^~ > ../block/blklogwrites.c:409:27: note: in expansion of macro ‘const_le64’ > 409 | .nr_entries = const_le64(0), > | ^~~~~~~~~~ > cc1: all warnings being treated as errors
Looks like const_le64() introduced in commit 845d80a8 is buggy. I wonder why we even added it when there is no user of it (this blklogwrites one is the first one, so it exposes the error). Of course, 0 is just as good as const_le64(0), so I'll just change it to that for now. But I suppose const_le64() should either be fixed (and used by something) or removed. Kevin
