On Tue, Mar 12, 2024 at 03:13:38PM +0100, Markus Armbruster wrote:
> Date: Tue, 12 Mar 2024 15:13:38 +0100
> From: Markus Armbruster <arm...@redhat.com>
> Subject: [PATCH 05/10] qapi: Inline and remove QERR_INVALID_PARAMETER
> definition
>
> From: Philippe Mathieu-Daudé <phi...@linaro.org>
>
> Address the comment added in commit 4629ed1e98
> ("qerror: Finally unused, clean up"), from 2015:
>
> /*
> * These macros will go away, please don't use
> * in new code, and do not add new ones!
> */
>
> Mechanical transformation using:
>
> $ sed -i -e "s/QERR_INVALID_PARAMETER,/\"Invalid parameter '%s'\",/" \
> $(git grep -lw QERR_INVALID_PARAMETER)
>
> Manually simplify qemu_opts_create(), and remove the macro definition
> in include/qapi/qmp/qerror.h.
>
> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> ---
> include/qapi/qmp/qerror.h | 3 ---
> qapi/opts-visitor.c | 2 +-
> util/qemu-option.c | 10 +++++-----
> 3 files changed, 6 insertions(+), 9 deletions(-)
Reviewed-by: Zhao Liu <zhao1....@intel.com>
