On 8/6/24 04:24, Philippe Mathieu-Daudé wrote:
From: Peter Maydell<[email protected]>Coverity notes that the code at the end of the loop in bmdma_prepare_buf() is unreachable. This is because in commit 9fbf0fa81fca8f527 ("ide: remove hardcoded 2GiB transactional limit") we removed the only codepath in the loop which could "break" out of it, but didn't notice that this meant we should also remove the code at the end of the loop. Remove the dead code. Resolves: Coverity CID 1547772 Signed-off-by: Peter Maydell<[email protected]> Reviewed-by: Kevin Wolf<[email protected]> Reviewed-by: Philippe Mathieu-Daudé<[email protected]> Signed-off-by: Philippe Mathieu-Daudé<[email protected]> --- v2: Break and return once at EOF --- hw/ide/pci.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson <[email protected]> r~
