> On 8 May 2025, at 8:20, Markus Armbruster <arm...@redhat.com> wrote:
>
> Markus Armbruster <arm...@redhat.com> writes:
>
>> Markus Armbruster <arm...@redhat.com> writes:
>>
>>> Nir Soffer <nir...@gmail.com> writes:
>
> [...]
>
>>>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>>>> index b1937780e1..7c95c9e36a 100644
>>>> --- a/qapi/block-core.json
>>>> +++ b/qapi/block-core.json
>>>> @@ -3293,8 +3293,9 @@
> ##
> # @BlockdevOptionsNull:
> #
> # Driver specific block device options for the null backend.
> #
> # @size: size of the device in bytes.
>
> Missing: default value.
This was not added by my change, but I can add another commit to specify the
default size.
But it would be better to make this required, default size does not make sense
for a block device, expect maybe 0, but this is not very useful default.
Can we break compatibility by requiring a size?