Eric Blake <ebl...@redhat.com> writes:
> On Wed, May 28, 2025 at 01:39:25PM +0200, Markus Armbruster wrote:
>> Eric Blake <ebl...@redhat.com> writes:
>>
>> > Prove that blockdev-mirror can now result in sparse raw destination
>> > files, regardless of whether the source is raw or qcow2. By making
>> > this a separate test, it was possible to test effects of individual
>> > patches for the various pieces that all have to work together for a
>> > sparse mirror to be successful.
>> >
>> > Note that ./check -file produces different job lengths than ./check
>> > -qcow2 (the test uses a filter to normalize); that's because when
>> > deciding how much of the image to be mirrored, the code looks at how
>> > much of the source image was allocated (for qcow2, this is only the
>> > written clusters; for raw, it is the entire file). But the important
>> > part is that the destination file ends up smaller than 3M, rather than
>> > the 20M it used to be before this patch series.
>> >
>> > Signed-off-by: Eric Blake <ebl...@redhat.com>
>> > Message-ID: <20250509204341.3553601-28-ebl...@redhat.com>
>> > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
>>
>> Fails for me:
>>
>
>> @@ -184,7 +184,7 @@
>> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
>> "event": "JOB_STATUS_CHANGE", "data": {"status": "null", "id": "job2"}}
>> {"return": {}}
>> Images are identical.
>> -Destination is sparse; expected sparse
>> +Destination is unknown; expected sparse
>
> Looks like the same failure Fiona reported; does this fix it?
>
> https://lists.gnu.org/archive/html/qemu-devel/2025-05/msg05567.html
It does not.
