On 17.05.2016 09:35, Fam Zheng wrote: > Signed-off-by: Fam Zheng <[email protected]> > --- > qemu-img-cmds.hx | 44 ++++++++++++++++++++++---------------------- > qemu-img.c | 1 + > qemu-img.texi | 3 +++ > 3 files changed, 26 insertions(+), 22 deletions(-) >
[...]
> diff --git a/qemu-img.texi b/qemu-img.texi
> index afaebdd..b91f2e1 100644
> --- a/qemu-img.texi
> +++ b/qemu-img.texi
> @@ -77,6 +77,9 @@ progress is reported when the process receives a
> @code{SIGUSR1} signal.
> @item -q
> Quiet mode - do not print any output (except errors). There's no progress bar
> in case both @var{-q} and @var{-p} options are used.
> +@item -L
> +disables image locking. The image will not be locked, other processes can
> +access and lock this image while we are using it.
I think "while it is in use by qemu-img" sounds more program-y.
Other than that, the patch is OK unless you decide that indeed two
distinct flags for source and target make sense for convert and rebase.
Max
> @item -S @var{size}
> indicates the consecutive number of bytes that must contain only zeros
> for qemu-img to create a sparse image during conversion. This value is
> rounded
>
signature.asc
Description: OpenPGP digital signature
