On Jan 25 17:56, Philippe Mathieu-Daudé wrote:
> On 25/1/26 07:42, Akihiko Odaki wrote:
> > The bootindex suffix can be used as long as the property is alive.
> 
> True, so:
> 
> Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
> 
> But maybe it shouldn't (we should g_strdup it like other QOM fields).
> 

Do you mean that device_add_bootindex_property() should g_strdup the
suffix? And then free it in property_release_bootindex()? That would
make sense to me.

My grepping tells me that nvme-ns is the only device where the suffix is
dynamic. In all other places it is a literal.

Attachment: signature.asc
Description: PGP signature

Reply via email to