On Wed, Feb 4, 2026, 4:21 AM Daniel P. Berrangé <[email protected]> wrote:
> On Tue, Feb 03, 2026 at 03:35:08PM -0500, John Snow wrote: > > With the qemu.qmp and qemu.machine dependencies now installed by default > > at configure time and additional dependencies required by functional > > testing installed on demand, there is no longer any reason to have an > > explicit target. > > > > FIXME: This forces image regeneration for vm tests whenever Make > > determines that the image needs to be rebuilt; which is a regression > > over the previous behavior. > > IIUC because you always pass the '--force' flag now. If the deps show it > is dirty though, this seems right ? Is it a regression or was previous > code incorrectly NOT forcing rebuild in all needed cases ? It is pretty > confusing logic there. > Yeah, admittedly I don't understand what the old conditional was even doing... I forgot I still had this fixme in here, mea culpa. I suppose I kind of figured that if someone complained, I'd fix it then...? because I'm not sure exactly what regressed or in what cases, or how to even roll back and test the behavior pre-fix. *loud shrugging* > > > > Signed-off-by: John Snow <[email protected]> > > --- > > tests/Makefile.include | 22 ++-------------------- > > tests/vm/Makefile.include | 24 +++++++----------------- > > 2 files changed, 9 insertions(+), 37 deletions(-) > > Reviewed-by: Daniel P. Berrangé <[email protected]> > > > With regards, > Daniel > -- > |: https://berrange.com -o- > https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- > https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- > https://www.instagram.com/dberrange :| > >
