John Snow <[email protected]> writes:

> On Fri, Mar 20, 2026, 10:13 AM Markus Armbruster <[email protected]> wrote:
>
>> John Snow <[email protected]> writes:
>>
>> > Ugly hack, gets the job done. Likely many simplifications can be made as
>> > a result, but I didn't make any of them. There are some inconsistencies
>> > with human-readable vs ENUM_NAMES in error messages in this patch, but
>> > it appears to work anyway.
>> >
>> > Consider this patch more of a rough idea and not anything approximating
>> > the kind of code you'd want to see from an Enterprise Linux Senior
>> > Software Engineer.
>> >
>> > Signed-off-by: John Snow <[email protected]>
>> > ---
>> >  scripts/qapi/parser.py | 39 +++++++++++++++++++++++----------------
>> >  1 file changed, 23 insertions(+), 16 deletions(-)
>>
>> Missing: update to docs/devel/qapi-code-gen.rst.  Suggest to put in a
>> FIXME, so we don't forget.
>>
>
> ACK
>
>
>> Missing: test coverage.
>>
>
> Do we need to test every possible sequence, or just some characteristic
> examples...?

Let's start with characteristic examples.


Reply via email to