On Tue, 06/14 16:49, Max Reitz wrote: > On 18.05.2016 07:53, Fam Zheng wrote: > > Otherwise the job is orphaned and block_job_cancel_sync in > > bdrv_close_all() when quiting will hang. > > > > A simple reproducer is running blockdev-backup from null-co:// to > > null-co://. > > > > Cc: [email protected] > > Signed-off-by: Fam Zheng <[email protected]> > > --- > > block/backup.c | 34 ++++++++++++++++++---------------- > > 1 file changed, 18 insertions(+), 16 deletions(-) > > Sorry for having waited so long (I was thinking that maybe Jeff wanted > to take this patch), but now the patch no longer applies and I don't > feel comfortable with just fixing it up myself; git-backport-diff tells > me the required changes are "[0015] [FC]".
Oh it turns out this patch is superseded by commit 91ab68837933232bcef99da7c968e6d41900419b Author: Kevin Wolf <[email protected]> Date: Thu Apr 14 12:59:55 2016 +0200 backup: Don't leak BackupBlockJob in error path Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]> Reviewed-by: Alberto Garcia <[email protected]> So let's just drop it. Fam
