On Wed, 29 Jun 2016 13:37:15 +0200 Marc-André Lureau <[email protected]> wrote:
> Hi > > On Fri, Jun 24, 2016 at 7:55 AM, Michael S. Tsirkin <[email protected]> wrote: > > From: Cornelia Huck <[email protected]> > > > > Have vhost and dataplane use the new api for transports that > > have been converted. > > > > Signed-off-by: Cornelia Huck <[email protected]> > > Reviewed-by: Fam Zheng <[email protected]> > > Reviewed-by: Stefan Hajnoczi <[email protected]> > > Reviewed-by: Michael S. Tsirkin <[email protected]> > > Signed-off-by: Michael S. Tsirkin <[email protected]> > > --- > > This patch and further break vhost-user-test: > > QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/vhost-user-test > /x86_64/vhost-user/read-guest-mem: binding does not support host notifiers > qemu-system-x86_64: unable to start vhost net: 38: falling back on > userspace virtio > ** > ERROR:tests/vhost-user-test.c:162:wait_for_fds: assertion failed: (s->fds_num) > Aborted (core dumped) Yes, there's an || that needs to be a && (too late to fix), and the mechanism does not work for vhost (currently working on a fix; our fallback is too good since it only prints a message but otherwise works).
