On Fri 08 Jul 2016 04:23:03 PM CEST, Max Reitz wrote: >> + blk_id = qemu_opts_id(opts); >> + > > Side note: The "id" variable is supposed to contain the exact same > value, but the string it points to is invalidated by the > qdict_del(bs_opts, "id") call. > > So indeed we need to obtain the ID anew here (or we'd have to do > g_strdup() before and g_free() after, which is cumbersome). But > regarding the variable itself, you could have actually reused "id" (I > only noticed that just now). > > But that's just a minor thing, so: > > Reviewed-by: Max Reitz <mre...@redhat.com>
Ok, if this series doesn't get a new version feel free to modify the patch when you apply it. Berto
