On Thu 28 Jul 2016 12:33:51 AM CEST, Eric Blake <[email protected]> wrote: >> + if (cfg->buckets[i].max && cfg->buckets[i].max < >> cfg->buckets[i].avg) { >> + error_setg(errp, "if bps_max/iops_max is set it cannot be lower" >> + " than the bps/iops values"); > > Feels a bit long, I'd be fine with "bps_max/iops_max must not be lower > than bps/iops values". But the idea makes sense.
That's not strictly true since the default value of bps_max is 0 (unless we forbid setting it explicitly to 0 as well). Berto
