Am 14.10.2016 um 17:39 hat Stefan Hajnoczi geschrieben: > On Mon, Oct 10, 2016 at 11:07:09AM +0800, Xu Tian wrote: > > If backing file can not open when do image rebase, flag 'ret' not > > assign a non-zero value, then qemu-img process exit with code zero. > > Assign value '-1' to flag 'ret' after report error message to fix > > this defeat. > > I suggest rewording the commit description: > > img_rebase() returns 0 (success) when opening the backing file fails > because 'ret' isn't set.
I already reworded it a bit when I applied the patch (it was sent twice somehow and I replied to the other one): If the backing file cannot be opened when doing qemu-img rebase, the variable 'ret' was not assigned a non-zero value, and the qemu-img process terminated with exit code zero. Fix this. Kevin
Description: PGP signature