This small series removes the need for using the -iscsi argument
by directly supporting all the -iscsi options against the block
device config eg instead of
$QEMU \
-object secret,id=sec0,data=123456 \
-drive driver=iscsi,file=iscsi://catbus/iqn.fedora:kvm/2 \
-iscsi initiator-name=fish,user=test,password-secret=sec0,timeout=234
you can now do it all against -drive
$QEMU \
-object secret,id=sec0,data=123456 \
-drive driver=iscsi,file=iscsi://catbus/iqn.fedora:kvm/2,\
initiator-name=fish,user=test,password-secret=sec0,timeout=234
This fixes the problem that you cannot associate -drive instances
with -iscsi args reliably due to IQNs containing chracters that
QEMU forbids in QemuOpts ID strings.
Pino had previously sent a patch to do this for initiator-name
back in the 2.6 dev cycle
https://lists.nongnu.org/archive/html/qemu-block/2016-04/msg00246.html
This series supports all the -iscsi option names, except for
'password' which is intentionally left out as it is insecure
and replaced by 'password-secret'.
Daniel P. Berrange (2):
iscsi: reduce code duplication parsing -iscsi opts
iscsi: support most -iscsi opts against block dev opts
block/iscsi.c | 145 ++++++++++++++++++++++++++++++----------------------------
block/iscsi.h | 79 ++++++++++++++++++++++++++++++++
vl.c | 36 ++++-----------
3 files changed, 163 insertions(+), 97 deletions(-)
create mode 100644 block/iscsi.h
--
2.9.3
