On 2016/12/6 0:22, Eric Blake wrote:
On 12/05/2016 02:35 AM, zhanghailiang wrote:
We use these two options to identify which disk is
shared

Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Signed-off-by: Zhang Chen <zhangchen.f...@cn.fujitsu.com>
---
v2:
- add these two options for BlockdevOptionsReplication to support
   qmp blockdev-add command.
- fix a memory leak found by Changlong
---

+++ b/qapi/block-core.json
@@ -2232,12 +2232,19 @@
  #          node who owns the replication node chain. Must not be given in
  #          primary mode.
  #
+# @shared-disk-id: #optional The id of shared disk while in replication mode.
+#
+# @shared-disk: #optional To indicate whether or not a disk is shared by
+#               primary VM and secondary VM.

Both of these need a '(since 2.9)' designation since they've missed 2.8,
and could probably also use documentation on the default value assumed
when the parameter is omitted.


OK, i will add it in next version, thanks.

+#
  # Since: 2.8
  ##
  { 'struct': 'BlockdevOptionsReplication',
    'base': 'BlockdevOptionsGenericFormat',
    'data': { 'mode': 'ReplicationMode',
-            '*top-id': 'str' } }
+            '*top-id': 'str',
+            '*shared-disk-id': 'str',
+            '*shared-disk': 'bool' } }

  ##
  # @NFSTransport




Reply via email to