On 24/01/2017 13:53, Peter Lieven wrote:
> Am 24.01.2017 um 13:52 schrieb Paolo Bonzini:
>>
>> On 24/01/2017 13:49, Peter Lieven wrote:
>>> +#ifdef CONFIG_LIBISCSI
>> The #ifdef is not needed here.
>
> Right, can you drop it or shall I send a V2?
Can do.
Paolo
> Peter
>
>>
>> Paolo
>>
>>> +static QemuOptsList qemu_iscsi_opts = {
>>> + .name = "iscsi",
>>> + .head = QTAILQ_HEAD_INITIALIZER(qemu_iscsi_opts.head),
>>> + .desc = {
>>> + {
>>> + .name = "user",
>>> + .type = QEMU_OPT_STRING,
>>> + .help = "username for CHAP authentication to target",
>>> + },{
>>> + .name = "password",
>>> + .type = QEMU_OPT_STRING,
>>> + .help = "password for CHAP authentication to target",
>>> + },{
>>> + .name = "password-secret",
>>> + .type = QEMU_OPT_STRING,
>>> + .help = "ID of the secret providing password for CHAP "
>>> + "authentication to target",
>>> + },{
>>> + .name = "header-digest",
>>> + .type = QEMU_OPT_STRING,
>>> + .help = "HeaderDigest setting. "
>>> + "{CRC32C|CRC32C-NONE|NONE-CRC32C|NONE}",
>>> + },{
>>> + .name = "initiator-name",
>>> + .type = QEMU_OPT_STRING,
>>> + .help = "Initiator iqn name to use when connecting",
>>> + },{
>>> + .name = "timeout",
>>> + .type = QEMU_OPT_NUMBER,
>>> + .help = "Request timeout in seconds (default 0 = no
>>> timeout)",
>>> + },
>>> + { /* end of list */ }
>>> + },
>>> +};
>>> +
>>> +static void iscsi_block_opts_init(void)
>>> +{
>>> + qemu_add_opts(&qemu_iscsi_opts);
>>> +}
>>> +
>>> +block_init(iscsi_block_opts_init);
>>> +#endif
>
>
