Am 16.02.2017 um 12:25 hat Kevin Wolf geschrieben: > Am 15.02.2017 um 11:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > > Auto loading bitmaps are bitmaps stored in the disk image, which should > > be loaded when the image is opened and become BdrvDirtyBitmaps for the > > corresponding drive. > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > > Reviewed-by: John Snow <js...@redhat.com> > > Reviewed-by: Max Reitz <mre...@redhat.com> > > Why do we need a new BlockDriver callback and special code for it in > bdrv_open_common()? The callback is only ever called immediately after > .bdrv_open/.bdrv_file_open, so can't the drivers just do this internally > in their .bdrv_open implementation? Even more so because qcow2 is the > only driver that supports this callback.
Actually, don't we have to call this in qcow2_invalidate_cache()? Currently, I think, after a migration, the autoload bitmaps aren't loaded. By moving the qcow2_load_autoloading_dirty_bitmaps() call to qcow2_open(), this would be fixed. Kevin
