On 21.02.2017 15:58, Kevin Wolf wrote: > We should not try to assign a not yet opened node as the backing file, > because as soon as the permission system is added it will fail. The > just added bdrv_new_open_driver() function is the right tool to open a > file with an internal driver, use it. > > In case anyone wonders whether that magic fake backing file to trigger a > special action on 'commit' actually works today: No, not for me. One > reason is that we've been adding a raw format driver on top for several > years now and raw doesn't support commit. Other reasons include that the > backing file isn't writable and the driver doesn't support reopen, and > it's also size 0 and the driver doesn't support bdrv_truncate. All of > these are easily fixable, but then 'commit' ended up in an infinite loop > deep in the vvfat code for me, so I thought I'd best leave it alone. I'm > not really sure what it was supposed to do anyway. > > Signed-off-by: Kevin Wolf <[email protected]> > --- > block/vvfat.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Max Reitz <[email protected]>
signature.asc
Description: OpenPGP digital signature
