Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 20170420075237.18219-1-f...@redhat.com Subject: [Qemu-devel] [PATCH v13 00/20] block: Image locking series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 2d5d050 tests: Add test-image-lock a0d4c3c file-posix: Add image locking in perm operations 17c490b osdep: Add qemu_lock_fd and qemu_unlock_fd 2383a28 block: Workaround drive-backup sync=none for image locking 63541e0 tests: Disable image lock in test-replication 354af7e file-posix: Add 'locking' option 9cf4312 tests: Use null-co:// instead of /dev/null as the dummy image 4f5bbc4 iotests: 172: Use separate images for multiple devices 76ff84d iotests: 091: Quit QEMU before checking image 82cf7cc iotests: 087: Don't attach test image twice b9329f3 iotests: 085: Avoid image locking conflict 8a52859 iotests: 055: Don't attach the target image already for drive-backup 4159096 iotests: 046: Prepare for image locking a8af152 iotests: 030: Prepare for image locking 1137b91 qemu-io: Add --unsafe-read option d66cf70 qemu-img: Update documentation for --unsafe-read 7f30dc1 qemu-img: Add --unsafe-read option to subcommands d392aa4 block: Don't require BLK_PERM_CONSISTENT_READ when unsafe open 03a43f3 block: Drop consistent read perm if opened unsafe a45035b block: Introduce BDRV_O_UNSAFE_READ === OUTPUT BEGIN === Checking PATCH 1/20: block: Introduce BDRV_O_UNSAFE_READ... Checking PATCH 2/20: block: Drop consistent read perm if opened unsafe... Checking PATCH 3/20: block: Don't require BLK_PERM_CONSISTENT_READ when unsafe open... Checking PATCH 4/20: qemu-img: Add --unsafe-read option to subcommands... Checking PATCH 5/20: qemu-img: Update documentation for --unsafe-read... Checking PATCH 6/20: qemu-io: Add --unsafe-read option... WARNING: line over 80 characters #140: FILE: qemu-io.c:621: + if (openfile(argv[optind], flags, writethrough, unsafe_read, opts)) { total: 0 errors, 1 warnings, 117 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 7/20: iotests: 030: Prepare for image locking... Checking PATCH 8/20: iotests: 046: Prepare for image locking... Checking PATCH 9/20: iotests: 055: Don't attach the target image already for drive-backup... Checking PATCH 10/20: iotests: 085: Avoid image locking conflict... Checking PATCH 11/20: iotests: 087: Don't attach test image twice... Checking PATCH 12/20: iotests: 091: Quit QEMU before checking image... Checking PATCH 13/20: iotests: 172: Use separate images for multiple devices... Checking PATCH 14/20: tests: Use null-co:// instead of /dev/null as the dummy image... WARNING: line over 80 characters #93: FILE: tests/virtio-scsi-test.c:198: + qs = qvirtio_scsi_start("-drive id=drv1,if=none,file=null-co://,format=raw"); total: 0 errors, 1 warnings, 56 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 15/20: file-posix: Add 'locking' option... Checking PATCH 16/20: tests: Disable image lock in test-replication... Checking PATCH 17/20: block: Workaround drive-backup sync=none for image locking... Checking PATCH 18/20: osdep: Add qemu_lock_fd and qemu_unlock_fd... Checking PATCH 19/20: file-posix: Add image locking in perm operations... WARNING: line over 80 characters #119: FILE: block/file-posix.c:451: + error_setg_errno(errp, -ret, "Failed to lock write byte exclusively"); WARNING: line over 80 characters #261: FILE: block/file-posix.c:743: + ret = qemu_lock_fd(new_lock_fd, RAW_LOCK_BYTE_NO_OTHER_WRITER, 1, false); WARNING: line over 80 characters #268: FILE: block/file-posix.c:750: + error_setg_errno(errp, -ret, "Failed to unlock old fd (share byte)"); WARNING: line over 80 characters #273: FILE: block/file-posix.c:755: + error_setg_errno(errp, -ret, "Failed to upgrade new fd (share byte)"); WARNING: line over 80 characters #279: FILE: block/file-posix.c:761: + error_setg_errno(errp, -ret, "Failed to unlock new fd (share byte)"); WARNING: line over 80 characters #284: FILE: block/file-posix.c:766: + error_setg_errno(errp, -ret, "Failed to downgrade new fd (write byte)"); WARNING: line over 80 characters #291: FILE: block/file-posix.c:773: + ret = qemu_lock_fd(old_lock_fd, RAW_LOCK_BYTE_NO_OTHER_WRITER, 1, false); WARNING: line over 80 characters #325: FILE: block/file-posix.c:807: + ret = qemu_lock_fd(new_lock_fd, RAW_LOCK_BYTE_NO_OTHER_WRITER, 1, false); WARNING: line over 80 characters #332: FILE: block/file-posix.c:814: + error_setg_errno(errp, -ret, "Failed to unlock old fd (share byte)"); WARNING: line over 80 characters #337: FILE: block/file-posix.c:819: + error_setg_errno(errp, -ret, "Failed to upgrade new fd (share byte)"); WARNING: line over 80 characters #344: FILE: block/file-posix.c:826: + ret = qemu_lock_fd(new_lock_fd, RAW_LOCK_BYTE_NO_OTHER_WRITER, 1, false); WARNING: line over 80 characters #346: FILE: block/file-posix.c:828: + error_setg_errno(errp, -ret, "Failed to downgrade new fd (share byte)"); WARNING: line over 80 characters #349: FILE: block/file-posix.c:831: + ret = qemu_lock_fd(old_lock_fd, RAW_LOCK_BYTE_NO_OTHER_WRITER, 1, false); WARNING: line over 80 characters #383: FILE: block/file-posix.c:865: + ret = qemu_lock_fd(new_lock_fd, RAW_LOCK_BYTE_NO_OTHER_WRITER, 1, false); WARNING: line over 80 characters #433: FILE: block/file-posix.c:915: + error_setg_errno(errp, -ret, "Failed to unlock old fd (write byte)"); WARNING: line over 80 characters #438: FILE: block/file-posix.c:920: + error_setg_errno(errp, -ret, "Failed to upgrade new fd (write byte)"); WARNING: line over 80 characters #447: FILE: block/file-posix.c:929: + error_setg_errno(errp, -ret, "Failed to downgrade new fd (write byte)"); WARNING: line over 80 characters #452: FILE: block/file-posix.c:934: + error_setg_errno(errp, -ret, "Failed to restore old fd (write byte)"); WARNING: line over 80 characters #481: FILE: block/file-posix.c:963: + ret = qemu_lock_fd(old_lock_fd, RAW_LOCK_BYTE_NO_OTHER_WRITER, 1, false); WARNING: line over 80 characters #483: FILE: block/file-posix.c:965: + error_setg_errno(errp, -ret, "Failed to downgrade old fd (share byte)"); WARNING: line over 80 characters #486: FILE: block/file-posix.c:968: + ret = qemu_lock_fd(new_lock_fd, RAW_LOCK_BYTE_NO_OTHER_WRITER, 1, false); ERROR: line over 90 characters #556: FILE: block/file-posix.c:1038: + {RAW_L_READ_SHARE_RW, RAW_L_READ_SHARE_RW, raw_lt_nop, false, false}, WARNING: line over 80 characters #557: FILE: block/file-posix.c:1039: + {RAW_L_READ_SHARE_RW, RAW_L_READ, raw_lt_from_unlock, true}, WARNING: line over 80 characters #558: FILE: block/file-posix.c:1040: + {RAW_L_READ_SHARE_RW, RAW_L_WRITE_SHARE_RW, raw_lt_from_unlock, true}, WARNING: line over 80 characters #559: FILE: block/file-posix.c:1041: + {RAW_L_READ_SHARE_RW, RAW_L_WRITE, raw_lt_from_unlock, true}, ERROR: line over 90 characters #561: FILE: block/file-posix.c:1043: + {RAW_L_READ, RAW_L_READ_SHARE_RW, raw_lt_nop, false, true}, ERROR: line over 90 characters #562: FILE: block/file-posix.c:1044: + {RAW_L_READ, RAW_L_READ, raw_lt_nop, false, false}, WARNING: line over 80 characters #563: FILE: block/file-posix.c:1045: + {RAW_L_READ, RAW_L_WRITE_SHARE_RW, raw_lt_read_to_write_share, true}, WARNING: line over 80 characters #564: FILE: block/file-posix.c:1046: + {RAW_L_READ, RAW_L_WRITE, raw_lt_read_to_write, true}, ERROR: line over 90 characters #566: FILE: block/file-posix.c:1048: + {RAW_L_WRITE_SHARE_RW, RAW_L_READ_SHARE_RW, raw_lt_nop, false, true}, WARNING: line over 80 characters #567: FILE: block/file-posix.c:1049: + {RAW_L_WRITE_SHARE_RW, RAW_L_READ, raw_lt_write_share_to_read, true}, ERROR: line over 90 characters #568: FILE: block/file-posix.c:1050: + {RAW_L_WRITE_SHARE_RW, RAW_L_WRITE_SHARE_RW, raw_lt_nop, false, false}, WARNING: line over 80 characters #569: FILE: block/file-posix.c:1051: + {RAW_L_WRITE_SHARE_RW, RAW_L_WRITE, raw_lt_write_share_to_write, true}, ERROR: line over 90 characters #571: FILE: block/file-posix.c:1053: + {RAW_L_WRITE, RAW_L_READ_SHARE_RW, raw_lt_nop, false, true}, WARNING: line over 80 characters #572: FILE: block/file-posix.c:1054: + {RAW_L_WRITE, RAW_L_READ, raw_lt_write_to_read, true}, WARNING: line over 80 characters #573: FILE: block/file-posix.c:1055: + {RAW_L_WRITE, RAW_L_WRITE_SHARE_RW, raw_lt_write_to_write_share, true}, ERROR: line over 90 characters #574: FILE: block/file-posix.c:1056: + {RAW_L_WRITE, RAW_L_WRITE, raw_lt_nop, false, false}, WARNING: line over 80 characters #658: FILE: block/file-posix.c:1140: + rec->func(op, s->lock_fd, lu->lock_fd, old_lock, new_lock, &error_abort); total: 7 errors, 31 warnings, 833 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 20/20: tests: Add test-image-lock... WARNING: line over 80 characters #149: FILE: tests/test-image-lock.c:115: + DPRINTF("from reopen %d, initial readonly: %d\n", from_reopen, initial_readonly); WARNING: line over 80 characters #284: FILE: tests/test-image-lock.c:250: + g_test_add_func("/image-lock/compat_after_reopen", test_compat_after_reopen); total: 0 errors, 2 warnings, 273 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org