On Fri, May 05, 2017 at 11:30:11AM +0200, Paolo Bonzini wrote: > could you pass BDRV_REQ_MAY_UNMAP for the flags here if the deallocate > bit (dword 12 bit 25) is set?
In fact we should do that unconditonally. The deallocate bit is new in 1.3 (which we don't claim to support) and forces deallocating, but NVMe already allows for this behavior without the flag (we in fact explicitly clarified this in an ECN for 1.2.1).
