On Wed, May 17, 2017 at 08:10:51PM +0800, Fam Zheng wrote: > On Wed, 05/17 13:59, Kevin Wolf wrote: > > Am 17.05.2017 um 04:13 hat Fam Zheng geschrieben: > > > On Fri, 05/05 18:21, Fam Zheng wrote: > > > > This is the case in our docker tests, as we use --net=none there. Skip > > > > this method. > > > > > > Ping. Is this patch okay? > > > > I thought you might want to respond to Dan's comment. If you don't plan > > to make the change he suggests, let me know and I'll queue the patch as > > it is. > > This check is enough for me and I think it's good to go.
That's fine with me - i didn't intend my comments to be a blocker. In general getaddrinfo should only return IPv6 addrs, if IPv6 is actually usable. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|