16.02.2017 16:04, Fam Zheng wrote:
+ dbms->node_name = bdrv_get_node_name(bs);
+ if (!dbms->node_name || dbms->node_name[0] == '\0') {
+ dbms->node_name = bdrv_get_device_name(bs);
+ }
+ dbms->bitmap = bitmap;
What protects the case that the bitmap is released before migration completes?
What is the source of such deletion? qmp command? Theoretically possible.
I see the following variants:
1. additional variable BdrvDirtyBItmap.migration, which forbids bitmap
deletion
2. make bitmap anonymous (bdrv_dirty_bitmap_make_anon) - it will not be
available through qmp
what do you think?
--
Best regards,
Vladimir
