John Snow <js...@redhat.com> writes: > On 08/07/2017 10:45 AM, Markus Armbruster wrote: >> Byte counts should use QAPI type 'size' (uint64_t). BlockDirtyInfo >> member @count is 'int' (int64_t). bdrv_query_dirty_bitmaps() computes >> @count from bdrv_get_dirty_count() in uint64_t, then implicitly >> converts to int64_t. Before the commit before previous, the >> conversion was in bdrv_get_dirty_count() instead. >> >> Change member @count to 'size'. >> >> query-block now reports @count values above 2^63-1 correctly instead >> of their (negative) two's complement. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > Assuming there's no "gotcha" here introduced by changing the QAPI, then > ACK; but you're the expert there, so I trust you!
Juan asked the same question on PATCH 15, see my reply there. > Reviewed-by: John Snow <js...@redhat.com> Thanks!
