On Thu 24 Aug 2017 02:06:00 PM CEST, Manos Pitsidianakis wrote: > +bool throttle_group_exists(const char *name) > +{ > + return throttle_group_by_name(name) != NULL; > +}
I realized that you needed to add throttle_group_exists() after all because you need it in block/throttle.c > /* error if name is duplicate */ > - if (throttle_group_by_name(tg->name) != NULL) { > + if (throttle_group_exists(tg->name)) { > error_setg(errp, "A group with this name already exists"); > return; > } In that case you can also add it directly in patch #4 so you don't need to change this line here. But I won't oppose if you prefer to keep it like this, so either way Reviewed-by: Alberto Garcia <be...@igalia.com> Berto