On 12/09/2017 14:57, Kevin Wolf wrote: > Am 12.09.2017 um 14:31 hat Paolo Bonzini geschrieben: >> On 12/09/2017 12:40, Kevin Wolf wrote: >>> Am 09.08.2017 um 23:55 hat Paolo Bonzini geschrieben: >>>> Split "check" parts from tests part. >>>> >>>> For the directory setup, the actual computation of directories goes >>>> in "check", while the sanity checks go in the tests. >>>> >>>> Signed-off-by: Paolo Bonzini <[email protected]> >>> >>> Same comment as for patch 1, we may want to keep this working. >> >> Can you explain what is the use case? For local symlinks I (sort of) >> understand it, but not here. This as far as I understand is code that >> never runs. > > Sorry, somehow I replied to the wrong patch... > > This was meant as a comment for patch 9 ('do not search for binaries in > the current directory'). > >> My preferred alternatives would be one of these: >> >> - add a patch 13 that restores the local symlink feature on top of the >> cleaned up code. >> >> - later, rewrite "check" in Python now that it is clear what code is >> part of it and what code is part of the tests. > > Do you really think that removing and the reintroducing the feature is > easier than just keeping it in the first place?
Nah, sorry, I was confused -- I thought the feature was in some common.* file, but it's straight in "check". I'll get rid of patch 9 and the './qemu' hunk of patch 1. Paolo
