On 09/19/2017 04:14 AM, Thomas Huth wrote: > On 19.09.2017 10:06, Paolo Bonzini wrote: >> On 13/09/2017 21:08, John Snow wrote: > [...] >>> Farewell, bitrot code. >>> >>> Reviewed-by: John Snow <js...@redhat.com> >>> >>> Out of curiosity, I wonder ... >>> >>> jhuston@probe (foobar) ~/s/qemu> git grep '#if 0' | wc -l >>> 320 >> >> $ git grep -c '#if 0' | sort -k2 --field-separator=: -n >> ... >> hw/net/eepro100.c:21 >> target/ppc/cpu-models.h:76 >> >> whoa :) > > Igor recently already removed the dead definitions from cpu-models.c : > > https://git.qemu.org/?p=qemu.git;a=commitdiff;h=aef779605779579afbafff > > I guess we could now remove the corresponding dead definitions from the > header, too... > > Any volunteers? > > Thomas >
Well, I can just take a chainsaw to it blindly if you want to critique it.
