On 2017-10-10 11:27, Kevin Wolf wrote: > Am 13.09.2017 um 20:19 hat Max Reitz geschrieben: >> With this, the mirror_top_bs is no longer just a technically required >> node in the BDS graph but actually represents the block job operation. >> >> Signed-off-by: Max Reitz <[email protected]> >> --- >> block/mirror.c | 18 ++++++++++-------- >> 1 file changed, 10 insertions(+), 8 deletions(-) >> >> diff --git a/block/mirror.c b/block/mirror.c >> index 2ece38094d..9df4157511 100644 >> --- a/block/mirror.c >> +++ b/block/mirror.c >> @@ -43,8 +43,8 @@ typedef struct MirrorBlockJob { >> RateLimit limit; >> BlockBackend *target; >> BlockDriverState *mirror_top_bs; >> - BlockDriverState *source; >> BlockDriverState *base; >> + BdrvChild *source; > > Is it actually useful to store source seperately when we already have > mirror_top_bs->backing?
I'll take a look whether it is, and if it isn't, I'll probably add that as a separate patch (to keep this one as simple as it is). I imagine it is not, right. Max
signature.asc
Description: OpenPGP digital signature
