Am 15.11.2017 um 20:41 hat Peter Maydell geschrieben: > On 6 November 2017 at 16:55, Kevin Wolf <kw...@redhat.com> wrote: > > error_setg_errno() takes a positive errno code. > > > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > > --- > > block.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/block.c b/block.c > > index 684cb018da..f6415547fe 100644 > > --- a/block.c > > +++ b/block.c > > @@ -998,7 +998,7 @@ static int bdrv_backing_update_filename(BdrvChild *c, > > BlockDriverState *base, > > ret = bdrv_change_backing_file(parent, filename, > > base->drv ? base->drv->format_name : > > ""); > > if (ret < 0) { > > - error_setg_errno(errp, ret, "Could not update backing file link"); > > + error_setg_errno(errp, -ret, "Could not update backing file link"); > > } > > > > if (!(orig_flags & BDRV_O_RDWR)) { > > -- > > 2.13.6 > > Just noticed going through coverity warnings that this didn't > make it into rc1 -- could we get it in for rc2, please?
Yes. I was sick at the start of the week and Max didn't include my queue in his pull request, so all the patches I had queued missed -rc1 and will be sent for -rc2 instead. Kevin