06.02.2018 20:29, Daniel P. Berrangé wrote:
On Tue, Feb 06, 2018 at 08:16:42PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Support default luks options in VM.add_drive and in new library
function qemu_img_create. Use it in 205 iotests.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
---
instead of
[PATCH] iotests: 205: support only raw format
let's just support luks. This patch also makes it simple to support
luks in any other python iotest.
tests/qemu-iotests/205 | 4 ++--
tests/qemu-iotests/iotests.py | 33 +++++++++++++++++++++++++++++++++
2 files changed, 35 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 5a10b2d534..4b9a4445cd 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -58,6 +58,13 @@ qemu_default_machine = os.environ.get('QEMU_DEFAULT_MACHINE')
socket_scm_helper = os.environ.get('SOCKET_SCM_HELPER', 'socket_scm_helper')
debug = False
+luks_default_secret_id = 'luks_secret_default_iotests_id'
Can we just call this "keysec0", so we matchh convention used by
the shell script based tests.
Here I'm trying to avoid intersection with some user-defined id.
+luks_default_secret_data = '12345'
The 'check' script exports an environment variable IMGKEYSECRET
that is intended to be used as the default password for LUKS.
agree, missed this.
+luks_default_secret_object = 'secret,id=' + luks_default_secret_id + \
+ ',data=' + luks_default_secret_data
+luks_default_key_secret_opt = 'key-secret=' + luks_default_secret_id
Regards,
Daniel
--
Best regards,
Vladimir