On Sat, Feb 03, 2018 at 07:16:18AM +0100, Stefan Hajnoczi wrote: > v2: > * It was unnecessary to avoid duplicate iscsi_schedule_bh() calls since this > function already protects against duplicate calls internally [Stefan] > > Patches 1 & 2 are cleanups. > > Patch 3 fixes cancellation of ioctls. Felipe showed me a trace where an acb > is > cancelled and then completes twice. The second time around crashes QEMU. > > Compile-tested only. > > Felipe: Please let us know if this fixes the issue you are seeing. Thanks! > > Stefan Hajnoczi (3): > block/iscsi: drop unused IscsiAIOCB->buf field > block/iscsi: take iscsilun->mutex in iscsi_timed_check_events() > block/iscsi: fix ioctl cancel use-after-free > > block/iscsi.c | 33 ++++++++++++++++++++++----------- > 1 file changed, 22 insertions(+), 11 deletions(-)
Thanks for the reviews, Paolo and Felipe. Paolo: Please merge this, I'll send an additional patch that works around libiscsi's missing cancellation callback.
signature.asc
Description: PGP signature
