On 02/27/2018 03:21 PM, Eric Blake wrote: > On 02/23/2018 05:51 PM, John Snow wrote: >> Signed-off-by: John Snow <js...@redhat.com> >> --- >> tests/qemu-iotests/056 | 195 >> +++++++++++++++++++++++++++++++++++++++++++++ >> tests/qemu-iotests/056.out | 4 +- >> 2 files changed, 197 insertions(+), 2 deletions(-) >> > > I'm not sure if this covers everything in the series, but it looks like
It definitely doesn't! > a reasonable expansion and hits a lot of the highlights. At any rate, > it's always better to add tests, and the test passing is a good bet that > the new code will be harder to regress. > More to follow, but I was afraid of wasting time if this series didn't look on the whole serviceable. I'll probably focus efforts on expanding blockjob-txn and blockjob unit tests. > Reviewed-by: Eric Blake <ebl...@redhat.com> >
