On Tue 06 Mar 2018 04:11:17 PM CET, Kevin Wolf wrote: > I've finished the review now, the rest looks correct. > > The only other thing I wondered is about the cases where you pass a > NULL errp because the callers don't get an Error parameter, so they > can't pass it on. Some of these callers already use error_report(), so > it would be okay to use error_report_err() for an error returned by > qcow2_validate_table(), too. I think that would improve the messages.
Good idea, I'll change that and resend the series. Berto