Hi Emilio!
Looked through qdist, if I understand correctly, it saves each added
(with different value) element. It is not effective for disk io timing -
we'll have too much elements. In my approach, histogram don't grow, it
initially have several ranges and counts hits to each range.
06.03.2018 20:49, Emilio G. Cota wrote:
On Tue, Mar 06, 2018 at 16:00:17 +0000, Stefan Hajnoczi wrote:
On Wed, Feb 07, 2018 at 03:50:35PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Vladimir Sementsov-Ogievskiy (2):
block/accounting: introduce latency histogram
qapi: add block latency histogram interface
(snip)
5 files changed, 228 insertions(+), 1 deletion(-)
The feature looks good. I posted documentation and code readability
suggestions.
Hi Vladimir,
Did you consider using qdist? For reference, see commit bf3afd5f419
and/or grep 'qdist'.
Thanks,
Emilio
--
Best regards,
Vladimir
