Am 04.04.2018 um 17:41 hat Peter Krempa geschrieben: > On Tue, Apr 03, 2018 at 08:09:49 -0500, Eric Blake wrote: > > On 04/03/2018 06:08 AM, Kevin Wolf wrote: > > > The legacy command line interface gets the socket path from an option > > > called 'socket'. QAPI in contract uses SocketAddress, where the > > > corresponding option is called 'path'. > > > > > > Fix the gluster block driver to accept both 'socket' and 'path', with > > > 'path' being the preferred syntax. > > > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1545155 > > > > > > Cc: [email protected] > > > Signed-off-by: Kevin Wolf <[email protected]> > > > --- > > > block/gluster.c | 21 +++++++++++++++++---- > > > 1 file changed, 17 insertions(+), 4 deletions(-) > > Thanks for fixing this. I'm using the new syntax in the -blockdev code > in libvirt and since I'm qapi- schema-checking the results, it would > not be possible to use the legacy approach.
-blockdev is validated against the schema on the QEMU side, too. The legacy option can only be used with -drive. > > Reviewed-by: Eric Blake <[email protected]> > > > > Should we also add a deprecation warning for 'socket' and update the > > deprecation documentation, so we can start the clock ticking on getting > > rid of maintaining the back-compat glue forever? > > Well, that won't be as easy. Since there is at least one qemu release > which declared this in the QAPI schema but did not support using it it's > hard for libvirt to detect that this was fixed, and thus we can't infer > a capability which would be used to switch to the new-syntax only. Markus wanted to add some way to declare capabilities for a command in the schema that could be queried with schema introspection and would cover such cases. I think we even discussed this with you at KVM Forum? Eric, do you happen to know if there were any patches on the list related to this? Kevin
signature.asc
Description: PGP signature
