Eric Blake <ebl...@redhat.com> wrote: > On 05/08/2018 07:21 AM, Juan Quintela wrote: >> "Michael S. Tsirkin" <m...@redhat.com> wrote: >>> When pulling in headers that are in the same directory as C file (as >>> opposed to one in include/), we should use its relative path, without a >>> directory. Directory based path works more or less by accident. >> >> No, it is not by accident. >> qemu-version.h and config-host.h are on the root directory. I could >> agree with moving them. >> > >>> -#include "migration/qemu-file.h" >>> +#include "qemu-file.h" >> >> Substitite for "./qemu-file.h"? >> >> My wonder here is what happens if we end with a file with the same name in >> two places. > > We already have at least: > > include/qapi/qmp/qjson.h > migration/qjson.h > > so it's not necessarily a theoretical question (things work now, but > renaming one or the other header may be in order as part of > consolidating everything into the /include hierarchy)
Internal ones also? The whole reason why I moved them to migration/* in the first place was to be sure that they are internal, and that nobody else uses them. Later, Juan. PD. And yes, I realize that we include $(ROOT) in the include path, and then #include "migration/migration.h" still works from any place. sniff
