On 05/29/2018 01:48 PM, Philippe Mathieu-Daudé wrote:
> Use error_report() + abort() instead of error_setg(&error_abort),
> as suggested by the "qapi/error.h" documentation:
>
> Please don't error_setg(&error_fatal, ...), use error_report() and
> exit(), because that's more obvious.
> Likewise, don't error_setg(&error_abort, ...), use assert().
>
Didn't realize this was bad form (Why do we have it?)
> Use abort() instead of the suggested assert() because the error message
> already got displayed.
>
Update the suggestion?
> Suggested-by: Eric Blake <[email protected]>
> Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: John Snow <[email protected]>
Acked-by: John Snow <[email protected]>
