On Mon 18 Jun 2018 04:15:07 PM CEST, Kevin Wolf wrote: >> @@ -2850,7 +2850,8 @@ static BlockReopenQueue >> *bdrv_reopen_queue_child(BlockReopenQueue *bs_queue, >> int flags, >> const BdrvChildRole *role, >> QDict *parent_options, >> - int parent_flags) >> + int parent_flags, >> + bool keep_old_opts) > > Can we change the semantics of keep_old_opts so that flags is completely > ignored for keep_old_opts=false? > > Flags are one of the reasons why the behaviour of bdrv_reopen() is > rather complex and I'd prefer not having that complexity in a public > interface. To be honest, I wouldn't be sure that I could write a > correct documentation with it.
I think so. In this series if keep_old_opts is false the only possible flags are either 0 or BDRV_O_RDWR | BDRV_O_ALLOW_RDWR, depending on the value of "read-only" option. Berto
