On Fri 08 Jun 2018 02:32:28 PM CEST, Ari Sundholm wrote: > The guest OS may perform writes which are aligned to the logical > sector size instead of the physical one, so logging at this granularity > records the writes performed on the block device most faithfully. > > Signed-off-by: Ari Sundholm <a...@tuxera.com> > --- > block/blklogwrites.c | 47 ++++++++++++++++++++++++++++++++--------------- > 1 file changed, 32 insertions(+), 15 deletions(-) > > diff --git a/block/blklogwrites.c b/block/blklogwrites.c > index 216367f..decf5e5 100644 > --- a/block/blklogwrites.c > +++ b/block/blklogwrites.c > @@ -47,6 +47,8 @@ struct log_write_entry { > > typedef struct { > BdrvChild *log_file; > + uint32_t sectorsize; > + uint32_t sectorbits; > uint64_t cur_log_sector; > uint64_t nr_entries; > } BDRVBlkLogWritesState; > @@ -67,6 +69,8 @@ static int blk_log_writes_open(BlockDriverState *bs, QDict > *options, int flags, > goto fail; > } > > + s->sectorsize = BDRV_SECTOR_SIZE; /* May be updated later */ > + s->sectorbits = BDRV_SECTOR_BITS; > s->cur_log_sector = 1; > s->nr_entries = 0;
I haven't looked closely into this series so sorry if there's something that I'm overlooking, but this caught my attention: why do you have a patch that improves a driver that you introduced earlier in this same series? Berto