On Sat, Nov 17, 2018 at 09:01:57PM -0600, Eric Blake wrote: > On 11/16/18 9:53 AM, Daniel P. Berrangé wrote: > > The helpers for starting/stopping qemu-nbd in 058 will be useful in > > other test cases, so move them into a common.nbd file. > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > --- > > > +function nbd_server_start_unix_socket() > > +{ > > + nbd_server_stop > > + $QEMU_NBD -v -t -k "$nbd_unix_socket" $@ & > > Needs to be "$@" to properly preserve whitespace and/or empty arguments (the > latter if someone passes -x '' for a default-named export).
ok Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|