On Wed, Nov 21, 2018 at 05:30:53PM +0000, Vladimir Sementsov-Ogievskiy wrote: > Hi Daniel! > > After moving compression to threads in Qcow2 it's an obvious next step to > "threadyfy" encryption in Qcow2 too. > > But it turned out to be not as simple as I assumed. If I call > qcrypto_block_encrypt > in parallel threads with the same first argument (block), it just produce > wrong > things (pattern verification fails in iotests)..
Yes, this makes sense, because the underlying crypto impls all require that their state is only used from a single thread at any time. What's likely happening is that the IV is being scrambled so we're encrypting with the wrong tweak. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
