20.12.2018 5:29, John Snow wrote: > When making a backup of a dirty bitmap (for transactions), we want to > restore that backup whether or not the bitmap is enabled or not. > > It is perfectly valid to write into bitmaps that are disabled. It is > only illegitimate for the guest to have done so. > > Remove this assertion. > > Signed-off-by: John Snow <[email protected]>
Reviewed-by: Vladimir Sementsov-Ogievskiy <[email protected]> > --- > block/dirty-bitmap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c > index 89fd1d7f8b..6b688394e4 100644 > --- a/block/dirty-bitmap.c > +++ b/block/dirty-bitmap.c > @@ -625,7 +625,6 @@ void bdrv_clear_dirty_bitmap(BdrvDirtyBitmap *bitmap, > HBitmap **out) > void bdrv_restore_dirty_bitmap(BdrvDirtyBitmap *bitmap, HBitmap *backup) > { > HBitmap *tmp = bitmap->bitmap; > - assert(bdrv_dirty_bitmap_enabled(bitmap)); > assert(!bdrv_dirty_bitmap_readonly(bitmap)); > bitmap->bitmap = backup; > hbitmap_free(tmp); > -- Best regards, Vladimir
