On 14.01.19 14:10, Max Reitz wrote: > On 29.12.18 13:20, Vladimir Sementsov-Ogievskiy wrote: >> Simplify backup_incremental_init_copy_bitmap using the function >> bdrv_dirty_bitmap_next_dirty_area. >> >> Note: move to job->len instead of bitmap size: it should not matter but >> less code. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> >> --- >> block/backup.c | 40 ++++++++++++---------------------------- >> 1 file changed, 12 insertions(+), 28 deletions(-) > > Overall: What is this function even supposed to do? To me, it looks > like it marks all areas in job->copy_bitmap dirty that are dirty in > job->sync_bitmap. > > If so, wouldn't just replacing this by hbitmap_merge() simplify things > further?
Ah, no, because they would need to have the same granularity... Max
signature.asc
Description: OpenPGP digital signature
