Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/27] Block layer patches Message-id: [email protected] Type: series === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/1548942405-760115-1-git-send-email-andrey.shinkev...@virtuozzo.com -> patchew/1548942405-760115-1-git-send-email-andrey.shinkev...@virtuozzo.com - [tag update] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone' Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc' Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF' Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe' Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios' Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware' Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode' Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios' Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa' Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios' Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot' Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot' Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex' Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3' Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3' Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into 'capstone'... Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf' Cloning into 'dtc'... Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536' Cloning into 'roms/QemuMacDrivers'... Submodule path 'roms/QemuMacDrivers': checked out 'd4e7d7ac663fcb55f1b93575445fcbca372f17a7' Cloning into 'roms/SLOF'... Submodule path 'roms/SLOF': checked out '9b7ab2fa020341dee8bf9df6c9cf40003e0136df' Cloning into 'roms/ipxe'... Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17' Cloning into 'roms/openbios'... Submodule path 'roms/openbios': checked out '441a84d3a642a10b948369c63f32367e8ff6395b' Cloning into 'roms/openhackware'... Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5' Cloning into 'roms/qemu-palcode'... Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097' Cloning into 'roms/seabios'... Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307' Cloning into 'roms/seabios-hppa'... Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0' Cloning into 'roms/sgabios'... Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a' Cloning into 'roms/skiboot'... Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc' Cloning into 'roms/u-boot'... Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943' Cloning into 'roms/u-boot-sam460ex'... Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588' Cloning into 'tests/fp/berkeley-softfloat-3'... Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037' Cloning into 'tests/fp/berkeley-testfloat-3'... Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3' Cloning into 'ui/keycodemapdb'... Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce' Switched to a new branch 'test' efda24f scsi-disk: Add device_id property e2900fc scsi-disk: Don't use empty string as device id 0839ab4 qtest.py: Wait for the result of qtest commands 4d30da6 block: Fix invalidate_cache error path for parent activation 22f3081 iotests/236: fix transaction kwarg order 7a0e2ea iotests: Filter second BLOCK_JOB_ERROR from 229 64be774 virtio-scsi: Forbid devices with different iothreads sharing a blockdev 26077d4 scsi-disk: Acquire the AioContext in scsi_*_realize() bf17763 virtio-scsi: Move BlockBackend back to the main AioContext on unplug 925ffa2 block: Eliminate the S_1KiB, S_2KiB, ... macros cd95c7e block: Remove blk_attach_dev_legacy() / legacy_dev code 42f5a22 block: Apply auto-read-only for ro-whitelist drivers 15999b8 uuid: Make qemu_uuid_bswap() take and return a QemuUUID ac89b28 block/vdi: Don't take address of fields in packed structs d112419 block/vpc: Don't take address of fields in packed structs cbbb11d vmdk: Reject excess extents in blockdev-create 197749e iotests: Add VMDK tests for blockdev-create e0ff53e iotests: Filter cid numbers in VMDK extent info b4db4e6 vmdk: Implement .bdrv_co_create callback d57f723 vmdk: Refactor vmdk_create_extent 9e413c8 iotests: Make 234 stable 02cde0d block: Fix hangs in synchronous APIs with iothreads 7cc628d block: Replace qdict_put() by qdict_put_obj() where appropriate 7b62d1f qemu-iotests: add test case for dmg 3768be8 qcow2: Assert that refcount block offsets fit in the refcount table 5853e2c mirror: Block the source BlockDriverState in mirror_start_job() 67b66ab mirror: Release the dirty bitmap if mirror_start_job() fails === OUTPUT BEGIN === 1/27 Checking commit 67b66ab807fe (mirror: Release the dirty bitmap if mirror_start_job() fails) 2/27 Checking commit 5853e2cbf763 (mirror: Block the source BlockDriverState in mirror_start_job()) 3/27 Checking commit 3768be89c8a6 (qcow2: Assert that refcount block offsets fit in the refcount table) 4/27 Checking commit 7b62d1fcaac8 (qemu-iotests: add test case for dmg) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100755 total: 0 errors, 1 warnings, 80 lines checked Patch 4/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/27 Checking commit 7cc628dd759a (block: Replace qdict_put() by qdict_put_obj() where appropriate) 6/27 Checking commit 02cde0d15bcd (block: Fix hangs in synchronous APIs with iothreads) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #253: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #584: FILE: tests/test-block-iothread.c:327: +/* Test synchronous operations that run in a different iothread, so we have to WARNING: Block comments use a trailing */ on a separate line #585: FILE: tests/test-block-iothread.c:328: + * poll for the coroutine there to return. */ total: 0 errors, 3 warnings, 529 lines checked Patch 6/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/27 Checking commit 9e413c810961 (iotests: Make 234 stable) 8/27 Checking commit d57f723d9fc7 (vmdk: Refactor vmdk_create_extent) WARNING: line over 80 characters #126: FILE: block/vmdk.c:2114: + flat, compress, zeroed_grain, NULL, opts, errp)) { total: 0 errors, 1 warnings, 104 lines checked Patch 8/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/27 Checking commit b4db4e6f3761 (vmdk: Implement .bdrv_co_create callback) WARNING: line over 80 characters #218: FILE: block/vmdk.c:2075: + bdrv_get_full_backing_filename_from_filename(blk_bs(blk)->filename, backing_file, WARNING: line over 80 characters #373: FILE: block/vmdk.c:2174: + bool flat, bool split, bool compress, WARNING: line over 80 characters #391: FILE: block/vmdk.c:2192: + rel_filename = g_strdup_printf("%s-flat%s", data->prefix, data->postfix); WARNING: line over 80 characters #408: FILE: block/vmdk.c:2209: +static int coroutine_fn vmdk_co_create_opts(const char *filename, QemuOpts *opts, total: 0 errors, 4 warnings, 658 lines checked Patch 9/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/27 Checking commit e0ff53ef8fd6 (iotests: Filter cid numbers in VMDK extent info) 11/27 Checking commit 197749ef359c (iotests: Add VMDK tests for blockdev-create) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #12: new file mode 100755 ERROR: trailing whitespace #283: FILE: tests/qemu-iotests/237.out:28: + format: $ ERROR: trailing whitespace #310: FILE: tests/qemu-iotests/237.out:55: + format: $ ERROR: trailing whitespace #337: FILE: tests/qemu-iotests/237.out:82: + format: $ total: 3 errors, 1 warnings, 586 lines checked Patch 11/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/27 Checking commit cbbb11d6502a (vmdk: Reject excess extents in blockdev-create) 13/27 Checking commit d1124190ecfc (block/vpc: Don't take address of fields in packed structs) 14/27 Checking commit ac89b289a8db (block/vdi: Don't take address of fields in packed structs) 15/27 Checking commit 15999b866202 (uuid: Make qemu_uuid_bswap() take and return a QemuUUID) 16/27 Checking commit 42f5a22f03e8 (block: Apply auto-read-only for ro-whitelist drivers) 17/27 Checking commit cd95c7ec2558 (block: Remove blk_attach_dev_legacy() / legacy_dev code) 18/27 Checking commit 925ffa2853e3 (block: Eliminate the S_1KiB, S_2KiB, ... macros) 19/27 Checking commit bf177638a426 (virtio-scsi: Move BlockBackend back to the main AioContext on unplug) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #33: new file mode 100755 total: 0 errors, 1 warnings, 123 lines checked Patch 19/27 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/27 Checking commit 26077d4126c7 (scsi-disk: Acquire the AioContext in scsi_*_realize()) 21/27 Checking commit 64be774a1d82 (virtio-scsi: Forbid devices with different iothreads sharing a blockdev) 22/27 Checking commit 7a0e2eabf7c1 (iotests: Filter second BLOCK_JOB_ERROR from 229) 23/27 Checking commit 22f30810a6be (iotests/236: fix transaction kwarg order) 24/27 Checking commit 4d30da6acfc5 (block: Fix invalidate_cache error path for parent activation) 25/27 Checking commit 0839ab44d2bf (qtest.py: Wait for the result of qtest commands) 26/27 Checking commit e2900fcf8987 (scsi-disk: Don't use empty string as device id) 27/27 Checking commit efda24f4843e (scsi-disk: Add device_id property) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
