19.02.2019 15:02, Thomas Huth wrote: > On 19/02/2019 12.59, Stefan Hajnoczi wrote: >> Tests 235 and 238 do not require the kvm accelerator. TCG works fine. >> >> Use the default accelerator instead of requiring kvm. >> >> Suggested-by: Thomas Huth <[email protected]> >> Signed-off-by: Stefan Hajnoczi <[email protected]> >> --- >> tests/qemu-iotests/235 | 1 - >> tests/qemu-iotests/238 | 1 - >> 2 files changed, 2 deletions(-) >> >> diff --git a/tests/qemu-iotests/235 b/tests/qemu-iotests/235 >> index d6edd97ab4..329da8f0c2 100755 >> --- a/tests/qemu-iotests/235 >> +++ b/tests/qemu-iotests/235 >> @@ -49,7 +49,6 @@ qemu_img_create('-f', iotests.imgfmt, '-o', >> 'preallocation=metadata', disk, >> str(size)) >> >> vm = QEMUMachine(iotests.qemu_prog) >> -vm.add_args('-machine', 'accel=kvm') > > According to the initial commit log of 235: > > "iotests: simple mirror test with kvm on 1G image" > > ... so I assume KVM was used on purpose here? > > Thomas >
As I remember kvm is not really necessary, and test have a comment about it: # And it didn't reproduce if at least one of the following: ... # 3. drop kvm and use iotests.VM() (maybe, because of qtest) (however, it still # reproduces, if just drop kvm, but gdb failed to produce full backtraces # for me) But the comment should be updated with this patch. -- Best regards, Vladimir
