Daniel P. Berrangé <[email protected]> writes:

> Error reporting for user_creatable_add_opts_foreach was changed so that
> it no longer called 'error_report_err' in:
>
>   commit 7e1e0c11127bde81cff260fc6859690435c509d6
>   Author: Markus Armbruster <[email protected]>
>   Date:   Wed Oct 17 10:26:43 2018 +0200
>
>     qom: Clean up error reporting in user_creatable_add_opts_foreach()
>
> Some callers were updated to pass in "&error_fatal" but all the ones in
> qemu-img were left passing NULL. As a result all errors went to
> /dev/null instead of being reported to the user.
>
> Signed-off-by: Daniel P. Berrangé <[email protected]>

Mea culpa, I have no idea how this happened.

Reviewed-by: Markus Armbruster <[email protected]>

Reply via email to