On 4/29/19 6:02 PM, Thomas Huth wrote: > On 29/04/2019 17.53, Peter Maydell wrote: >> On Mon, 29 Apr 2019 at 16:34, Thomas Huth <th...@redhat.com> wrote: >>> >>> On 25/04/2019 17.53, Philippe Mathieu-Daudé wrote: >>>> Hi Thomas, >>>> >>>> On 4/18/19 8:00 PM, Thomas Huth wrote: >>>>> Dependencies have been determined by looking at hw/arm/virt.c >>>>> >>>>> Signed-off-by: Thomas Huth <th...@redhat.com> >>>>> --- >>>>> default-configs/arm-softmmu.mak | 11 +---------- >>>>> hw/arm/Kconfig | 19 +++++++++++++++++++ >>>>> hw/arm/Makefile.objs | 3 ++- >>>>> 3 files changed, 22 insertions(+), 11 deletions(-) >> >>>> Without -nodefaults I get: >>>> qemu-system-aarch64: Unsupported NIC model: virtio-net-pci >>>> This is expected. >>> >>> Yes, it should still work with "-nic none" or "-nodefaults". >> >> Er, if you need either -nic none or -nodefaults after this >> patch then this would be a change in behaviour, which seems >> wrong to me. > > No worry, this only applies to compiling builds where you run "configure > --without-default-devices". For normal builds, virtio-net should still > be included fine. ... at least I hope this is what Philippe was talking > about ... but for me it's working fine when I run "configure" normally.
Yes, I tested both cases, without --without-default-devices it works as expected (no behaviour change). With --without-default-devices (this is a new configure switch) it is probably required to run QEMU with -nodefaults.
