From: Andrey Shinkevich <[email protected]> On a file system used by the customer, fallocate() returns an error if the block is not properly aligned. So, bdrv_co_pwrite_zeroes() fails. We can handle that case the same way as it is done for the unsupported cases, namely, call to bdrv_driver_pwritev() that writes zeroes to an image for the unaligned chunk of the block.
Suggested-by: Denis V. Lunev <[email protected]> Signed-off-by: Andrey Shinkevich <[email protected]> Reviewed-by: John Snow <[email protected]> Message-id: 1554474244-553661-1-git-send-email-andrey.shinkev...@virtuozzo.com Message-Id: <1554474244-553661-1-git-send-email-andrey.shinkev...@virtuozzo.com> Signed-off-by: Stefan Hajnoczi <[email protected]> --- block/io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/io.c b/block/io.c index dfc153b8d8..0412a51314 100644 --- a/block/io.c +++ b/block/io.c @@ -1516,7 +1516,7 @@ static int coroutine_fn bdrv_co_do_pwrite_zeroes(BlockDriverState *bs, assert(!bs->supported_zero_flags); } - if (ret == -ENOTSUP && !(flags & BDRV_REQ_NO_FALLBACK)) { + if (ret < 0 && !(flags & BDRV_REQ_NO_FALLBACK)) { /* Fall back to bounce buffer if write zeroes is unsupported */ BdrvRequestFlags write_flags = flags & ~BDRV_REQ_ZERO_WRITE; -- 2.21.0
