Am 06.06.2019 um 14:01 hat Markus Armbruster geschrieben: > Signed-off-by: Markus Armbruster <[email protected]> > --- > This is on top of the fixup I appended to my review of v4. I'd squash > all three patches together. > > The next patch needs to be updated for this. > > Unsquashed branch at git://repo.or.cz/qemu/armbru.git branch > qapi-features. > > Let me know what you think.
As you know, I don't like the self._append_line function pointer and think it makes the code less readable. However, I also hope that I'll never have to touch this code again, whereas you as the maintainer will probably have to. So your taste is more imporant than mine. So for all I care, go ahead and squash in your changes. Kevin
