On 30.07.19 21:10, Eric Blake wrote: > On 7/30/19 12:25 PM, Max Reitz wrote: >> Signed-off-by: Max Reitz <[email protected]> >> --- >> block/qcow2-snapshot.c | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> > > Same problem as for 9/13 - should we really be throwing away the user's > data like this? (9/13 hits if the user has a small number of snapshots, > but each has enough extra data, that the overall table is bigger than we > like; 10/13 hits if the user has more snapshots than we like, but > otherwise they do the same thing).
The same arguments apply (though the “it must be a corruption” argument applies even more, because having more than 65536 snapshots just isn’t right.) Max
signature.asc
Description: OpenPGP digital signature
